List UI more optimized #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…state. make use of this cached method by passing on the state and it only renders if a new state. this makes game faster
…ly want to work with primitives when cache keys). only load frame images once, not for every instance of list ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But it is not as optimized as not render when mouse not over.
The not render when mouse not over is not good because it has some issues. Hover over an item and then move mouse sideways so it leaves the list. Then hover marker is still there because there is not update to remove it.
I think I can make this list even more optimized and I will keep optimizations on this branch.
Feel free to merge and remove the not-render-if-no-mouse-over thing if you find the list ui now being fast enough,